Key Value Options: add support for trailing semicolon#2140
Merged
yoavcloud merged 3 commits intoapache:mainfrom Jan 9, 2026
Merged
Key Value Options: add support for trailing semicolon#2140yoavcloud merged 3 commits intoapache:mainfrom
yoavcloud merged 3 commits intoapache:mainfrom
Conversation
iffyio
reviewed
Jan 9, 2026
src/parser/mod.rs
Outdated
Comment on lines
19314
to
19320
|
|
||
| #[test] | ||
| fn test_key_value_options_trailing_semicolon() { | ||
| let sql = "CREATE USER u1 option1 = 'value1' option2 = 'value2';"; | ||
| let ast = Parser::parse_sql(&GenericDialect, sql); | ||
| assert!(ast.is_ok()); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we have it as a test case in sqlparser_common.rs? also if the test case can cover all applicable dialects
yoavcloud
force-pushed
the
kv_options_trailing_semicolon
branch
from
23dc580 to
0814850
Compare
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.